Fix DEM casting to Mask by removing from_array overloading
#741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the fix is just 2 lines, should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #740
This is an easier fix than #740: Simply an
ifstatement depending on the output ofRaster.from_array.Another way to do this for a future re-work (if we want users to more easily subclass
Raster, for example) would be to separateRaster.from_array()into a non-public function that does the casting under-the-hood for all arithmetic ops (Raster._from_array(), which wouldn't be overloaded byDEM.from_array()) and a public function that works only for building a Raster as intended (refuses abooleaninput).Actually, we might have to already do this for the Xarray accessors, for consistency in the behaviour.
Resolves #739