Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape apostrophe #29

Open
mheppler opened this issue Jun 19, 2019 · 0 comments
Open

Escape apostrophe #29

mheppler opened this issue Jun 19, 2019 · 0 comments

Comments

@mheppler
Copy link

In the Dataverse issue tracker, an issue was created by @rmo-cdsp (IQSS/dataverse#5226), reporting a missing link in the account notification for file access requests.

On the second one, you can see the same page, but in french. But there is no link, just a {0}. I assume something went wrong when trying to retrieve the url to the dataset.

It was suggested by @mhvezina that an apostrophe needed to be escaped, and I was able to confirm this with this fix:

notification.requestFileAccess=Demande d''accès pour l''ensemble de données\u00A0: {0}.

There were also changes to this message in the English bundle in 4.10 release (IQSS/dataverse#5229), that adds more user information to the notification with two additional params.

I am opening this bug report in this new language packs repo, and closing the original issue in the dataverse repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant