Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"File access requested" notification : link not available in french #5226

Closed
rmo-cdsp opened this issue Oct 23, 2018 · 3 comments
Closed

"File access requested" notification : link not available in french #5226

rmo-cdsp opened this issue Oct 23, 2018 · 3 comments

Comments

@rmo-cdsp
Copy link
Contributor

Hello !

I can resume the problem with two pictures:
screenshot from 2018-10-23 16-00-45
screenshot from 2018-10-23 16-01-03

On the first one, you can see the user notification page with some "File access" notifications, with a link to the dataset.
On the second one, you can see the same page, but in french. But there is no link, just a {0}. I assume something went wrong when trying to retrieve the url to the dataset.

@mhvezina
Copy link
Contributor

Could it be related to the non-escaping of the apostrophe in the French text? (Also there seems to be one apostrophe missing between "d" and "accès" in your example).
We ran into something similar. Try to escape all aportrophes... maybe with something like "Demande d''accès pour l''ensemble de données : {0}."

@pdurbin
Copy link
Member

pdurbin commented Nov 26, 2018

@mhvezina maybe! Are you interested in working on a pull request? 😄

@mheppler
Copy link
Contributor

@rmo-cdsp thank you for catching and reporting this issue. As of the 4.13 release (#5720), we have changed how the various language bundle are added to the application. The English bundle is the only language included with the app, and the other languages have been moved to a new dataverse-language-packs repo.

I am going to close this issue, since there is no longer a code fix that applies to the current Dataverse version, and have opened a new issue in that repo at GlobalDataverseCommunityConsortium/dataverse-language-packs#29. You can track the progress of this bug fix with that new issue.

@mhvezina, thank you for your comments here and suggesting a fix. I was able to confirm this solution in my local dev environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants