Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename role.editor to role.contributor #108

Conversation

tcoupin
Copy link
Contributor

@tcoupin tcoupin commented Oct 3, 2022

@qqmyers
Copy link
Member

qqmyers commented Mar 12, 2024

@tcoupin - trying to help clean up these old PRs. For this and your related #107 - it looks like the change in Dataverse was for 5.14, so does it make sense to update the 5.10 and 5.11 translations or should the changes go into a new 5.14 (or later) version?

@tcoupin
Copy link
Contributor Author

tcoupin commented Mar 18, 2024

I add my colleague @plecor who replace me on dataverse's subject at French IRD

@plecor
Copy link

plecor commented Mar 18, 2024

Hi,
The key was changed in 5.14 but the issue it fixes was itself introduced in 4.20 by IQSS/dataverse#6662

The 4.20 PR renamed the role alias 'editor' to 'contributor', meaning the bundle resolutions is looking for role.contributor.name instead of role.editor.name, see https://github.com/IQSS/dataverse/blob/a57ce53c7c683d05959683de66c03199e465c2ad/src/main/java/edu/harvard/iq/dataverse/authorization/DataverseRole.java#L133

So the key role.contributor.name only exists in Dataverse since 5.14 through IQSS/dataverse#9012, but is expected in the translation files since 4.20.

This PR is on 5.10 and not 4.20 because this is the one we are working with internally.

@qqmyers qqmyers merged commit 22a318d into GlobalDataverseCommunityConsortium:dataverse-v5.10 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants