Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update EKS and addon versions so that we can go from 1.28 -> 1.29 upgrade #181

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Oct 29, 2024

[…](feat: update EKS and addon versions so that we can go from 1.28 -> 1.29 upgrade)

Copy link

@venkatamutyala venkatamutyala changed the title feat: update EKS and addon versions so that we can go from 1.28 -> 1.… feat: update EKS and addon versions so that we can go from 1.28 -> 1.29 upgrade Oct 29, 2024
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Compatibility
Ensure that the updated EKS version (1.29) is compatible with the specified CoreDNS and Kube Proxy versions. Verify that these versions are recommended and supported together.

Default Version Update
Confirm that the new default versions for CoreDNS and Kube Proxy are the latest stable versions recommended for EKS 1.29. Check AWS documentation for any potential issues or recommendations.

Documentation Update
Verify that all references to EKS, CoreDNS, and Kube Proxy versions in the README have been updated consistently. Ensure the documentation accurately reflects the new versions and any changes in configuration.

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Enhancement
Update the default EKS version in variables to match the new configuration

Update the default value of the eks_version variable to match the new version (1.29)
used in the configuration. This ensures consistency and prevents potential version
mismatch issues.

variables.tf [200]

 variable "eks_version" {
   type        = string
-  default     = "1.27"
+  default     = "1.29"
   description = "The version of EKS to deploy"
 }
  • Apply this suggestion
Suggestion importance[1-10]: 9

Why: Updating the default EKS version in the variables file to match the new configuration is crucial for consistency and prevents potential version mismatch issues. This change directly aligns with the updates made in the PR, ensuring the configuration is coherent and functional.

9
Best practice
Update commented node pool configurations to match new Kubernetes and AMI versions

Consider updating the commented-out node pool configurations to match the new
Kubernetes version and AMI release version. This ensures consistency across the
configuration and prevents potential issues if these commented sections are
uncommented in the future.

tests/main.tf [11-18]

+#    {
+#      "kubernetes_version" : "1.29",
+#      "ami_release_version" : "1.29.8-20241024",
+#      "ami_type" : "AL2_x86_64",
+#      "instance_type" : "t3a.large",
+#      "name" : "glueops-platform-node-pool-1",
+#      "node_count" : 4,
 
-
  • Apply this suggestion
Suggestion importance[1-10]: 7

Why: The suggestion to update the commented-out node pool configurations ensures consistency and prevents potential issues if these sections are uncommented in the future. It aligns the configuration with the new Kubernetes and AMI versions, which is a good practice for maintainability.

7

💡 Need additional feedback ? start a PR chat

@venkatamutyala venkatamutyala merged commit 0e3c3bf into main Oct 29, 2024
6 checks passed
@venkatamutyala venkatamutyala deleted the feat/update-to-eks-1.29 branch October 29, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants