Skip to content

feat(admin-ui): allow users to install Agama Lab community projects from Admin UI #1862

Merged
duttarnab merged 16 commits intomainfrom
admin-ui-1846
Jan 9, 2025
Merged

feat(admin-ui): allow users to install Agama Lab community projects from Admin UI #1862
duttarnab merged 16 commits intomainfrom
admin-ui-1846

Conversation

@mjatin-dev
Copy link
Copy Markdown
Contributor

@mjatin-dev mjatin-dev commented Oct 21, 2024

closes 1846

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed for 'flex_admin_ui'

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@duttarnab
Copy link
Copy Markdown
Contributor

duttarnab commented Nov 6, 2024

This PR is on hold. It can be addressed once the APIs are available . Issue raised for API development: https://github.com/JanssenProject/jans/issues/9907.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed for 'flex_linux_setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

duttarnab
duttarnab requested changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

admin-ui/plugins/auth-server/redux/api/AgamaApi.js
'Content-Type': 'application/zip',
}
})
axios.post('/api/v1/agama-deployment/' + name, file, {
Copy link
Copy Markdown
Contributor

@duttarnab duttarnab Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use jans-config-api client for calling apis.

Copy link
Copy Markdown
Contributor Author

@mjatin-dev mjatin-dev Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duttarnab Yes, we could, but I encountered an error with the jans-config-api because we are using a file. That's why we are opting for Axios instead for some methods.

admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js Outdated
import {
getAgamaRepository,
getAgamaRepositoryFile,
} from "../../redux/features/agamaSlice";
Copy link
Copy Markdown
Contributor

@duttarnab duttarnab Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use alias here for example: https://github.com/GluuFederation/flex/blob/main/admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js#L28C32-L28C66

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed for 'flex_admin_ui'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@duttarnab duttarnab merged commit 981ac1b into main Jan 9, 2025
@duttarnab duttarnab deleted the admin-ui-1846 branch January 9, 2025 19:20
@mo-auto mo-auto mentioned this pull request Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duttarnab duttarnab duttarnab approved these changes

@syntrydy syntrydy Awaiting requested review from syntrydy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(admin-ui): allow users to install Agama Lab community projects from Admin UI

3 participants

@mjatin-dev @duttarnab @moabu