Dev 1.0.0 #131
Merged
Dev 1.0.0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrectly handling cough button mute_to_x
This prevents problems with writing, where if an issue occurs (such as the utility is stopped), or an error occurs during the profile write the original file isn't immediately corrupted or lost.
As with profiles, this prevents edge cases where the util may be in the middle of writing the settings when the util is exited, causing the settings to be corrupt, and the util having to restore from defaults. These are extreme edge cases, but they've occurred two or three times so far, so the goal is to help protect against them.
Do not try to reload udev when running on an immutable OS
Because we no longer unlatch the faders on the Mini when a channel is muted to all the fader remained lit up. This disables the lighting on the fader to simulate the previous behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for 1.0.0 release.