Add support for the Cursor and DesktopSize pseudo-encodings to enable…#28
Open
kaikaijiang wants to merge 7 commits intoGoddchen:mainfrom
Open
Add support for the Cursor and DesktopSize pseudo-encodings to enable…#28kaikaijiang wants to merge 7 commits intoGoddchen:mainfrom
kaikaijiang wants to merge 7 commits intoGoddchen:mainfrom
Conversation
Owner
|
@kaikaijiang awesome PR, thank you so much! I'll review in the coming days. |
Goddchen
added
documentation
Goddchen
requested changes
May 10, 2025
Goddchen
reviewed
May 10, 2025
kaikaijiang
force-pushed
the
feature/addSupportForInteractionMode
branch
from
54e2cbe to
d924c19
Compare
… proper interaction with the VNC server
kaikaijiang
force-pushed
the
feature/addSupportForInteractionMode
branch
from
d924c19 to
a8f359c
Compare
Author
|
@Goddchen thanks a lot for the review. I have modified based on your suggestion, please check. |
Signed-off-by: Goddchen <goddchen@gmail.com>
Signed-off-by: Goddchen <goddchen@gmail.com>
Signed-off-by: Goddchen <goddchen@gmail.com>
Goddchen
reviewed
May 14, 2025
Signed-off-by: Goddchen <goddchen@gmail.com>
Signed-off-by: Goddchen <goddchen@gmail.com>
Signed-off-by: Goddchen <goddchen@gmail.com>
Owner
|
I'll only have to test it now while it is running 😎 Hopefully will get to it today. |
Author
|
@Goddchen Thanks a lot for your time! I'm totally fine with the changes. 😊 |
Goddchen
reviewed
Jun 12, 2025
Comment on lines
+209
to
+221
| rectangle.encodingType.mapOrNull( | ||
| desktopSize: (final _) { | ||
| _config = _config.map( | ||
| (final Config c) => c.copyWith( | ||
| frameBufferHeight: rectangle.height, | ||
| frameBufferWidth: rectangle.width, | ||
| ), | ||
| ); | ||
| logger.info( | ||
| 'Desktop size updated to ${rectangle.width}x${rectangle.height}', | ||
| ); | ||
| }, | ||
| ); |
Owner
There was a problem hiding this comment.
question: @kaikaijiang shouldn't we be handling the cursor type here as well somehow? We have introduced it now, but there is no code to actually do something with it if we receive it. Or am I missing something here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the Cursor and DesktopSize pseudo-encodings to enable proper interaction with the VNC server.
Update the example file