Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Button to set FRC DS to open Elastic automatically #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmeraldWither
Copy link
Contributor

Closes #176

To keep consistency between Elastic updates, I restricted it to being only the WPILib installer versions, as that ensures that the install location of Elastic doesn't change (compared to someone installing it manually).

I am not quite sure how to test this code however, and Ill look into adding tests for this.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 24.07407% with 41 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (33ef283) to head (1ae5ea1).

Files with missing lines Patch % Lines
lib/widgets/settings_dialog.dart 37.14% 22 Missing ⚠️
lib/services/ds_interop.dart 0.00% 17 Missing ⚠️
lib/pages/dashboard_page.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   75.90%   75.58%   -0.33%     
==========================================
  Files          79       79              
  Lines        8625     8679      +54     
==========================================
+ Hits         6547     6560      +13     
- Misses       2078     2119      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner

Gold872 commented Jan 31, 2025

I think this could be a useful addition, however I'm not a huge fan of the idea of modifying DS config files from the dashboard, as a bug there could have some serious consequences if it modifies something incorrectly. While it's extremely unlikely for that to happen, it does create a potential failure point. Instead it would make more sense to have Elastic added as a dropdown in the driver station for future seasons, which has been talked about in the past.

In the meantime though it would be better to instead have the button open a link to the WPILib page on custom driver stations, which has an example for making elastic appear by default: https://docs.wpilib.org/en/stable/docs/software/driverstation/manually-setting-the-driver-station-to-start-custom-dashboard.html#dashboard-from-wpilib-installer

@EmeraldWither
Copy link
Contributor Author

Understandable, don't wanna brick a DS before a match. Maybe I can change the button to instead link to WPILib and also include some instructions on how to modify the file yourself tomorrow.
Could it still be possible to move the button to developer options instead? It already has a warning about possibly dangerous behavior, so it could be useful for people who know what they are doing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button/Option to set DS to open Elastic automatically
2 participants