Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BSO Great Again #80

Merged
merged 12 commits into from
Feb 14, 2025
Merged

Make BSO Great Again #80

merged 12 commits into from
Feb 14, 2025

Conversation

EctoplasmIsGood
Copy link
Contributor

Description

Removes chester from the sec item group, adds a new item group for BSO primaries, adds the chester under that item group, and adds the Energy shotgun to BSO under that item group. One of the commits is just me moving my code around cuz it looks funny.


Media

Example Media Embed


Changelog

🆑

  • add: Added new BSO primary item group
  • add: Added Energy Shotgun to BSO loadout (as a primary)
  • tweak: Removed chester from sec weapons item group, in favor of the new BSO primary item group.

Removes sec loadout tag from chester
Removes chester from sec loadout item group
Adds new item group for BSO officer loadout
Adds the energy shotgun to BSOs loadout as a primary
made stuff more uniform
@GoobBot GoobBot changed the title Make BSO great again Make BSO Great Again Feb 11, 2025
@EctoplasmIsGood
Copy link
Contributor Author

This might conflict with a change I made on EE, I have no clue. The first commit here is a commit I made on a PR to EE that was already merged, and idk if that'll have overlap but hopefully it shouldn't.

@EctoplasmIsGood
Copy link
Contributor Author

I dont like the linter at all.

@EctoplasmIsGood
Copy link
Contributor Author

I give up on the linter, I genuinely think its crying about a problem that doesn't matter at all, up to Durk if he cares or not.

@Verbalase
Copy link

we love bso powercreep

@EctoplasmIsGood
Copy link
Contributor Author

we love bso powercreep

It is what it is. This is to slowly put them up to par with HoS, considering BSO has far more reasons to be heavily armed than them. IC they also are a special agent sent directly from CC, and it makes sense they’d have better weapons if they’re expected to protect command by their lonesome.

also lifeline implants are gonna get added so it kinda ties it all together.

@angelofallars
Copy link
Contributor

Hey, I suggest opening this PR on the upstream repository of Goob MRP instead: https://github.com/Simple-Station/Einstein-Engine

@EctoplasmIsGood
Copy link
Contributor Author

Hey, I suggest opening this PR on the upstream repository of Goob MRP instead: https://github.com/Simple-Station/Einstein-Engine

I did not do this because TCJ does not like the idea of BSO having stronger weapons, hence why I did it here

@Aidenkrz
Copy link
Contributor

Goob-Station/Goob-Station#1603
this should just be upstreamed

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Aidenkrz Aidenkrz merged commit ee02cd8 into Goob-Station:master Feb 14, 2025
8 of 9 checks passed
GoobBot added a commit that referenced this pull request Feb 14, 2025
@EctoplasmIsGood EctoplasmIsGood deleted the patch-1 branch February 15, 2025 21:34
@EctoplasmIsGood EctoplasmIsGood restored the patch-1 branch February 15, 2025 21:34
@EctoplasmIsGood EctoplasmIsGood deleted the patch-1 branch February 15, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants