[#39] Auction index #103

nathan-schmidt-viget · 2023-12-18T21:20:34Z

Summary

This sets up the basic audition index page. It set up a template that pulls in a pattern to control the layout of the page.
We filter the images to use the featured image for the Auction if it's set. If not use the featured product image for the rewards Product associated with the Auction. If no featured product, falls back to the WooCommerce default image.

The Auction index gets added as a page which auto adds it to the default menu. (we may need to adjust this a bit, but the only way I could find in the newest WP version to update the menu dynamically)

I am setting the Auctions index to only show 9 posts per page, this is not setting the global # posts in the admin (used for blog index), but just changes on the Auction index.

Issues

Site visitors see All Auctions page on Nonprofit Site (See it Work) #39

Testing Instructions

Auction Menu

Create a new site
Go to the site dashboard and make sure we have an Auctions page in the pages section
Go to the new site and make sure that the first menu item on the site is Auctions

Image Testing

Go to a nonprofit site
Go to the Auction index page at /auctions/
Make sure it is pulling in the auction posts
Make sure it is pulling in the right images
- If the auction does not have a featured image it pulls from the Reward featured image
- If no Reward featured image it defaults to the WooCommerce image

Post Limit to 9

Create more than nine auctions
Make sure that the Auction index shows only the first nine.

Screenshots

Index

Default pagination

clatwell · 2023-12-18T22:03:31Z

This is looking great! Do you mind tackling some quick Nonprofit Site Header polish as part of this PR?

When a new Nonprofit Site is created, don't include Cart, Checkout, or Shop page links in the header by default
When a new Nonprofit Site is created, include a link to Our Auctions in the header by default

Thank you!!

nathan-schmidt-viget · 2023-12-18T23:22:45Z

@clatwell Totally, I had gotten the first part of the ticket completed and wanted to get the doc/images into a draft before I did the header link and # of posts. I just got both of these added.

I will have to look into removing the default WooCommerce pages in the header

themes/goodbids-nonprofit/inc/patterns.php

nathan-schmidt-viget · 2023-12-19T00:06:52Z

@clatwell We may need to move the "Remove WooCommerce page" to another ticket. As it looks like editing/updating the WP navigation block is not straightforward and the documentation is little to none (from what I can find).

It seems like we may be able to it by:

Creating a new navigation
Adding in our own pages
Assigning the header navigation to use our new navigation.

nathan-schmidt-viget · 2023-12-19T15:58:37Z

Did some research on the block navigation and seems like there is a ticket open to add a hook to block and navigation - WordPress/gutenberg#54904
~~But it looks like we can use this halfway/fix for now - WordPress/wordpress-develop#2168 I will try it out and see if it does what we need it to do.~~ That code was never merged...

bd-viget

We're getting into some exciting territory with the Auction Archive!! Let me know if you want to huddle about some of these comments, I'm not sure if it works, but I'd like to explore the possibility of utilizing the archive template.

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

bd-viget · 2023-12-19T16:13:00Z

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

+					'post_name'   => self::ARCHIVE_SLUG,
+				);
+
+				wp_insert_post( $page );


Instead of creating a page here with the same slug as the Archive, have you looked into customizing the Auction Archive Template (Appearance > Editor > Templates > Archive Gb Auction)?

Full disclosure, this is just speculation from me, I've never actually done it yet with FSE, but in theory, I would think we could do it. We can customize the Archive template from the FSE, so we should be able to use a custom template instead of building a new page.

Ping me if you want to chat about this.

Correct everything is set up to use Appearance > Editor > Templates > Archive Gb Auction and that is how you edit the Archive page. This is the only way to dynamically add a page to the main navigation as the main nav block pulls from the pages. The downside to this is we need to remove Cart/Account/Shop from the navigation. If we can figure out a way to update the navigation then we don't need this at all.

All of this has been in churn last evening and this morning as I keep finding "solutions" to the navigation, but they don't really fix our bigger problem.

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

themes/goodbids-nonprofit/inc/patterns.php

joshuapease

Can't say I have much WP knowledge to bring... but it looked good to me

joshuapease · 2023-12-19T16:54:35Z

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

+		add_action(
+			'goodbids_init_site',
+			function () {
+				$page = array(


Should this use square brackets instead?

[

Yes, it totally should! We are going to change directions a bit for the navigation so I am going to remove this second and see if we need it in the navigation PR.

nathan-schmidt-viget · 2023-12-19T18:47:31Z

@bd-viget I pulled out the navigation part and update the per_page to be set when a new site is init.

nathan-schmidt-viget · 2023-12-19T18:48:56Z

client-mu-plugins/goodbids/src/classes/Frontend/Patterns.php

-				$sample_pattern = [
-					'name'       => 'sample-pattern',
-					'path'       => GOODBIDS_PLUGIN_PATH . 'views/patterns/sample-pattern.php',
-					'title'      => __( 'GoodBids Sample Pattern', 'goodbids' ),
+				$auction_archive = [
+					'name'       => 'template-archive-auction',
+					'path'       => GOODBIDS_PLUGIN_PATH . 'views/patterns/template-archive-auction.php',
+					'title'      => __( 'Archive Auction', 'goodbids' ),
 					'categories' => [ 'goodbids' ],
-					'keywords'   => [ 'example', 'template', 'demo' ],
+					'keywords'   => [ 'non-profit', 'starter', 'archive' ],
 					'inserter'   => true,
 				];

 				$this->patterns = apply_filters(
 					'goodbids_block_patterns',
 					[
-						$sample_pattern,
+						$auction_archive,
 					]


Moves this from the theme pattern into the plugin pattern

bd-viget

Beautiful! Just a few tiny notes, but should be all set!

bd-viget · 2023-12-19T21:49:12Z

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

+					return $html;
+				}
+
+				$reward_id  = goodbids()->auctions->get_reward_product_id( $post_id );


With the update to your Auction page PR, this is a great example of when we would need to pass the ID into the method. 👍

bd-viget · 2023-12-19T21:50:42Z

client-mu-plugins/goodbids/src/classes/Auctions/Auctions.php

+
+				$reward_id  = goodbids()->auctions->get_reward_product_id( $post_id );
+				$product    = wc_get_product( $reward_id );
+				$image_html = $product->get_image();


Suggested change

$image_html = $product->get_image();

return $product->get_image();

I can't remember if the sprintf was doing something before, but if we no longer have anything to pass into the $image_html var, this can go ahead and return here.

bd-viget · 2023-12-19T21:52:16Z

client-mu-plugins/goodbids/src/classes/Network/Sites.php

+		add_action(
+			'goodbids_init_site',
+			function ( int $site_id ): void {
+				update_option(


Suggested change

update_option(

update_option( 'posts_per_page', 9 );

Very minor, but I usually only break things up into multiple lines if there easier to read. In this case, it might easier to keep this on 1 line since it's a pretty simple bit of code.

bd-viget · 2023-12-19T21:52:32Z

client-mu-plugins/goodbids/views/patterns/template-archive-auction.php

+ * @since 1.0.0
+ * @package GoodBids
+ */
+?>


Suggested change

?>

?>

Just need to add a line here.

* [#823] Restore Bid Variation due to catastrophic failure * [#823] Compare with highest value. * [#823] Make sure Auctioneer gets the correct value. * [#823] Make sure Bid increments correctly. * [#103] Forgot to commit this Author code

nathan-schmidt-viget requested a review from bd-viget December 18, 2023 23:29

nathan-schmidt-viget marked this pull request as ready for review December 18, 2023 23:29

nathan-schmidt-viget requested a review from joshuapease December 18, 2023 23:31

nathan-schmidt-viget commented Dec 18, 2023

View reviewed changes

themes/goodbids-nonprofit/inc/patterns.php Outdated Show resolved Hide resolved

nathan-schmidt-viget force-pushed the ns/39-auction-index branch from 8ec485e to e272621 Compare December 18, 2023 23:51

nathan-schmidt-viget added 4 commits December 19, 2023 08:12

[#39] setting up archive page

e02d989

[#39] Setting default image for Auction index

84dff8f

[#39] setting number of post per page on auction index

e6a2c41

[#39] adding auction archive page to nav

10373bd

nathan-schmidt-viget force-pushed the ns/39-auction-index branch from e272621 to 10373bd Compare December 19, 2023 15:12

[#39] pattern refactor to use plugin

d34d4de

bd-viget suggested changes Dec 19, 2023

View reviewed changes

[#39] fixing PR edits

92a9d4b

nathan-schmidt-viget force-pushed the ns/39-auction-index branch from 373f70f to 92a9d4b Compare December 19, 2023 16:50

joshuapease approved these changes Dec 19, 2023

View reviewed changes

[#39] removing page for menu

03573ac

nathan-schmidt-viget requested a review from bd-viget December 19, 2023 18:46

[#39] updating default post per page

e55bc45

nathan-schmidt-viget force-pushed the ns/39-auction-index branch from 49ac8dd to e55bc45 Compare December 19, 2023 18:48

nathan-schmidt-viget commented Dec 19, 2023

View reviewed changes

bd-viget approved these changes Dec 19, 2023

View reviewed changes

nathan-schmidt-viget merged commit 7ccc537 into main Dec 19, 2023
1 check passed

nathan-schmidt-viget deleted the ns/39-auction-index branch December 19, 2023 21:55

nathan-schmidt-viget mentioned this pull request Dec 20, 2023

Site visitors see All Auctions page on Nonprofit Site (See it Work) #39

Closed

bd-viget added a commit that referenced this pull request Mar 22, 2024

[#103] Forgot to commit this Author code

22817ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#39] Auction index #103

[#39] Auction index #103

nathan-schmidt-viget commented Dec 18, 2023 •

edited

Loading

clatwell commented Dec 18, 2023

nathan-schmidt-viget commented Dec 18, 2023 •

edited

Loading

nathan-schmidt-viget commented Dec 19, 2023 •

edited

Loading

nathan-schmidt-viget commented Dec 19, 2023 •

edited

Loading

bd-viget left a comment

bd-viget Dec 19, 2023

nathan-schmidt-viget Dec 19, 2023

joshuapease left a comment

joshuapease Dec 19, 2023

nathan-schmidt-viget Dec 19, 2023

nathan-schmidt-viget commented Dec 19, 2023

nathan-schmidt-viget Dec 19, 2023

bd-viget left a comment

bd-viget Dec 19, 2023

bd-viget Dec 19, 2023

bd-viget Dec 19, 2023

bd-viget Dec 19, 2023

	$image_html = $product->get_image();
	return $product->get_image();

[#39] Auction index #103

[#39] Auction index #103

Conversation

nathan-schmidt-viget commented Dec 18, 2023 • edited Loading

Summary

Issues

Testing Instructions

Auction Menu

Image Testing

Post Limit to 9

Screenshots

Index

Default pagination

clatwell commented Dec 18, 2023

nathan-schmidt-viget commented Dec 18, 2023 • edited Loading

nathan-schmidt-viget commented Dec 19, 2023 • edited Loading

nathan-schmidt-viget commented Dec 19, 2023 • edited Loading

bd-viget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuapease left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nathan-schmidt-viget commented Dec 19, 2023

Choose a reason for hiding this comment

bd-viget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nathan-schmidt-viget commented Dec 18, 2023 •

edited

Loading

nathan-schmidt-viget commented Dec 18, 2023 •

edited

Loading

nathan-schmidt-viget commented Dec 19, 2023 •

edited

Loading

nathan-schmidt-viget commented Dec 19, 2023 •

edited

Loading