simplify response success setting

GoodRx · Jan 24, 2019 · 4408c52 · 4408c52
1 parent 00851d0
commit 4408c52
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/braze/client.py b/braze/client.py
@@ -150,20 +150,14 @@ def __create_request(self, payload):
         response["status_code"] = r.status_code
 
         message = response["message"]
-        if message == "success" or message == "queued":
-            if not response["errors"]:
-                response["success"] = True
-            else:
-                # Non-Fatal errors
-                pass
+        response["success"] = (
+            message in ("success", "queued") and not response["errors"]
+        )
 
         if message != "success":
             # message contains the fatal error message from Braze
             raise BrazeClientError(message, response["errors"])
 
-        if "success" not in response:
-            response["success"] = False
-
         if "status_code" not in response:
             response["status_code"] = 0