Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment PlayBilling version to V5 #432

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

SayedElabady
Copy link
Contributor

Update PlayBilling version to V5, this is pending testing.

@SayedElabady SayedElabady marked this pull request as ready for review July 10, 2023 12:56
Copy link
Contributor

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of nits, overall looking good though.

playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
playbilling/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

@PEConn PEConn merged commit 5dd1eb4 into GoogleChrome:main Jul 12, 2023
2 checks passed
@SayedElabady SayedElabady deleted the play-billingV5-bump branch July 12, 2023 10:47
@khmyznikov
Copy link

@SayedElabady @PEConn guys this is in browser-helper release already? We have issues about it pwa-builder/PWABuilder#4213

@andreban
Copy link
Member

andreban commented Aug 2, 2023

Just checked MavenCentral. The compile dependency section points to billing version 5.2.1, which is the one updated in this PR. So, short answer is yes :D

@khmyznikov
Copy link

@andreban yeah looks like it was updated in bubblewrap just recently GoogleChromeLabs/bubblewrap#815 . Ok then, we need to update bubblewrap version on our side

@SayedElabady
Copy link
Contributor Author

SayedElabady commented Oct 3, 2023

Closes #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants