Update PlayBilling version to V6 #476
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| fail("Price change confirmation flow ended with result: " + result); | ||
| } | ||
| }); | ||
| fail("Price change confirmation flow is not supported"); |
There was a problem hiding this comment.
I think we can fail earlier. At the moment, the PaymentActivity is launched, it connects to Play Billing (which is async) and queries the SKUs (which is async) then hits this, but we know in PaymentActivity#onCreate if the request is for a price change confirmation flow.
I think you could instead add if (mMethodData.isPricechangeConfirmation) { fail(...) } as soon as we create the MethodData.
|
To check, you've run the tests locally and they still pass, right? |
Yes, tests pass locally |
WIP: API updates for Play Billing V6 migration