core(target-manager): ignore targets that don't implement `Target.get…

…TargetInfo`
GoogleChrome · Oct 10, 2024 · 1d36435 · 1d36435
1 parent 0c7c183
commit 1d36435
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/core/gather/driver/target-manager.js b/core/gather/driver/target-manager.js
@@ -128,7 +128,15 @@ class TargetManager extends ProtocolEventEmitter {
     let targetType;
 
     try {
-      const {targetInfo} = await newSession.sendCommand('Target.getTargetInfo');
+      // This can throw an error when attaching to certain target types.
+      // If a target type doesn't implement `Target.getTargetInfo` then Lighthouse should probably
+      // ignore it anyways.
+      const target = await newSession.sendCommand('Target.getTargetInfo').catch(() => null);
+      if (!target) {
+        return;
+      }
+
+      const {targetInfo} = target;
       targetType = targetInfo.type;
 
       // TODO: should detach from target in this case?