misc(build): use terser on inline assets

[connorjclark]

Saves ~32 KB in CDT bundle.

We did the same thing already for the viewer #9823, but the build-bundle never got the same treatment.

Here's what got trimmed:

minifying /Users/cjamcl/src/lighthouse/node_modules/axe-core/axe.min.js. saved 3.195 KB
minifying /Users/cjamcl/src/lighthouse/node_modules/js-library-detector/library/libraries.js. saved 26.963 KB

axe.min.js is quite big, and surfaced the fact that minifyFileTransform only worked if the amount of code fits in w/e Node decides to be the chunk size in the file streaming. Had to fix that.

[connorjclark]

Figured some wouldn't want this logged all the time.

[patrickhulce]

Who sees this? maybe behind a debug flag or something instead?

the dead code option is probably my last preference among

• just log it anyway
• log it when asked with a flag/env var/something
• never log it
• commented code

[patrickhulce]

I do get a smidge nervous about the quality of our devtools tests with changes like this though. it's times like these that full smoke coverage for DT would be awesome :)

how would you feel about skipping axe and just running on library detector for now since that's where most of the savings comes from anyway?

[patrickhulce]

Who sees this? maybe behind a debug flag or something instead?

the dead code option is probably my last preference among

• just log it anyway
• log it when asked with a flag/env var/something
• never log it
• commented code

[connorjclark]

I do get a smidge nervous about the quality of our devtools tests with changes like this though. it's times like these that full smoke coverage for DT would be awesome :)

We have yarn test-bundle, which loads the devtools bundle directly. We can add the a11y to yarn test-bundle. Is that sufficient?

[patrickhulce]

We can add the a11y to yarn test-bundle. Is that sufficient?

SGTM 👍

[patrickhulce]

✂️ ✂️