Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit(non-composited-animations): add UIString for custom properties #15571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

with-shrey
Copy link

Summary

Animating custom properties appear to always end up non-composited (at least outside of CSS painting), and get lumped with all the other non-composited CSS properties found in the trace (don't be surprised like me and note that this happens regardless of what the property is animating, e.g. animating translate through fixed values is usually composited, animating --yheight in translate: 0 var(--yheight) will not be).

Related Issues/PRs
Closes #14521

@with-shrey with-shrey changed the title audit(non-composited-animations): Add UIString for custom properties audit(non-composited-animations): add UIString for custom properties Oct 26, 2023
@with-shrey with-shrey marked this pull request as ready for review October 26, 2023 10:31
@with-shrey with-shrey requested a review from a team as a code owner October 26, 2023 10:31
@with-shrey with-shrey requested review from adamraine and removed request for a team October 26, 2023 10:31
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -91,9 +101,18 @@ function getActionableFailureReasons(failureCode, unsupportedProperties) {
.filter(reason => failureCode & reason.flag)
.map(reason => {
if (reason.text === UIStrings.unsupportedCSSProperty) {
const nonCustomUnSupportedProperties = unsupportedProperties
.filter(property => !property.startsWith('--'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
.filter(property => !property.startsWith('--'));
.filter(property => !property.startsWith('--'));

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure
Will do in a bit

@@ -91,9 +101,18 @@ function getActionableFailureReasons(failureCode, unsupportedProperties) {
.filter(reason => failureCode & reason.flag)
.map(reason => {
if (reason.text === UIStrings.unsupportedCSSProperty) {
const nonCustomUnSupportedProperties = unsupportedProperties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const nonCustomUnSupportedProperties = unsupportedProperties
const nonCustomUnsupportedProperties = unsupportedProperties

mustafacco7

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add new UIString for non-composited-animations due to custom properties
4 participants