Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(devtools): sync e2e #16160

Merged
merged 2 commits into from
Aug 22, 2024
Merged

tests(devtools): sync e2e #16160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b0a22
tests(devtools): sync e2e
adamraine Aug 22, 2024
50041ae
dbw
adamraine Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/test/smokehouse/test-definitions/dobetterweb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ const expectations = {
},
'render-blocking-resources': {
score: '<1',
numericValue: '>=85',
numericValue: '>=50',
details: {
items: [
{
Expand Down
10 changes: 6 additions & 4 deletions third-party/devtools-tests/e2e/lighthouse/devtools-settings_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,12 @@ describe('DevTools', function() {
statusCode: item.statusCode,
};
});
assert.deepEqual(trimmedRequests, [
{url: 'hello.html', statusCode: 200},
{url: 'basic.css', statusCode: -1}, // statuCode === -1 means the request failed
]);

// An extra basic.css request with status code -1 appears, but only in e2e tests
// This test is made more lenient since this only happens in the e2e environment
// b/359984292
assert.deepStrictEqual(trimmedRequests[0], {url: 'hello.html', statusCode: 200});
assert.deepStrictEqual(trimmedRequests[1], {url: 'basic.css', statusCode: -1});
});
});

Expand Down
Loading