report(viewer): minify inlined report-generator bundle#9596
report(viewer): minify inlined report-generator bundle#9596paulirish merged 4 commits intoGoogleChrome:masterfrom
Conversation
wardpeet
changed the title
wardpeet
force-pushed
the
feat/improve-viewer-bundle
branch
from
8b389c0 to
ced584d
Compare
wardpeet
force-pushed
the
feat/improve-viewer-bundle
branch
from
ced584d to
7aefe88
Compare
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
would fix the first checkbox in #2591!
I have my doubts that it will get accepted but i've already pushed it to my own npm account to get feedback on this change.
given the rate of change on brfs I also don't hold out a lot of hope, but it's worth a try :) Implementation looks 👍
build/build-viewer.js
Outdated
| /** | ||
| * @param {string} file | ||
| */ | ||
| readFileSyncTransform: file => { |
There was a problem hiding this comment.
probably pull this out into a top-level named function
brendankenny
changed the title
|
i love how you made webpack in browserify :) |
|
@connorjclark it's now called wardpack 😂 |
| * | ||
| * @param {string} file | ||
| */ | ||
| function minifyReadFileContent(file) { |
There was a problem hiding this comment.
I couldn't really find a proper name for this function, suggestions are welcome
|
I updated this PR but don't know how to push my changes to this PR, so I just opened a new one ... #9823 let's do thissss |
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
we're going to live with @wardpeet/brfs for now until/if browserify/brfs#94 gets looked at :)
|
My legacy will live on! 🎉 |
5 participants
Summary
Brfs inlines readFileSync functions from report/html/html-report-assets.js inside viewer.js to generate an html report when clicking on saveHtml.
I've added a PR 94 to enable options to transform the file content. I have my doubts that it will get accepted but i've already pushed it to my own npm account to get feedback on this change. I'm happy to publish this under a different namespace or packagename.
The new options allow us to run terser on our js files and compress them. We'll save 18.96KB. The smaller the better is what I was thinking especially for a tool like Lighthouse 💪.
Before:
After:
This commit e4bc45a is the one you should look at.
This PR builds further on #9594