Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guard to prevent errors in the onCLS() function #536

Merged
merged 22 commits into from
Sep 30, 2024
Merged

Conversation

philipwalton
Copy link
Member

This PR fixes an error where the CLS session window logic tries to access startTime of an undefined entry.

It's still a mystery how this can possibly happen, but given that at least three people have reported it over the years. It's probably worth adding a guard for:

Addresses the following issues:

(Note: the base branch here is temporary to make the diff easier to see. I'll updated it after the other PRs are merged into the v5 branch.)

Base automatically changed from baseline-widely-available to v5 September 30, 2024 22:12
@philipwalton philipwalton merged commit becca7c into v5 Sep 30, 2024
6 checks passed
@philipwalton philipwalton deleted the cls-error branch September 30, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants