Skip to content

Propagate errors in iframes so they terminate test harness.#115

Merged
brendandahl merged 1 commit intoGoogleChrome:mainfrom
brendandahl:propagate-errors
Mar 2, 2026
Merged

Propagate errors in iframes so they terminate test harness.#115
brendandahl merged 1 commit intoGoogleChrome:mainfrom
brendandahl:propagate-errors

Conversation

@brendandahl
Copy link
Collaborator

Errors in the test harness were causing the tests to hang until the timeout instead of terminating.

Errors in the test harness were causing the tests to hang until the
timeout instead of terminating.
Copy link
Collaborator

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

Copy link
Collaborator

@rmahdav rmahdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

(I am still not sure but looks like this change is another solution for part of my PR #113 . After you land it, I will rebase my PR and send it for review.)

@brendandahl brendandahl merged commit 5fb3ea7 into GoogleChrome:main Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants