Skip to content

Commit

Permalink
relax screenshot
Browse files Browse the repository at this point in the history
  • Loading branch information
jcscottiii committed Feb 9, 2024
1 parent 4ad5e5e commit faff453
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ deploy-local: configure-skaffold
delete-local:
skaffold delete -p local || true

port-forward-manual:
port-forward-manual: port-forward-terminate
kubectl wait --for=condition=ready pod/frontend
kubectl wait --for=condition=ready pod/backend
kubectl port-forward --address 127.0.0.1 pod/frontend 5555:5555 2>&1 >/dev/null &
kubectl port-forward --address 127.0.0.1 pod/backend 8080:8080 2>&1 >/dev/null &

port-forward-terminate:
pkill kubectl -9
pkill kubectl -9 || true

# Prerequisite target to start minikube if necessary
minikube-running:
Expand Down
5 changes: 4 additions & 1 deletion e2e/tests/overview-page.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,8 @@ import { test, expect } from '@playwright/test'
test('matches the screenshot', async ({ page }) => {
await page.goto('http://localhost:5555/')

await expect(page).toHaveScreenshot()
await expect(page).toHaveScreenshot({
// Temporarily allow a higher diff ratio as these tests become more stable
maxDiffPixelRatio: 0.05
})
})

0 comments on commit faff453

Please sign in to comment.