Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter components to features page #11

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Add filter components to features page #11

merged 5 commits into from
Feb 12, 2024

Conversation

dlaliberte
Copy link
Collaborator

@dlaliberte dlaliberte commented Feb 12, 2024 •
edited
Loading

This PR just adds initial components for the filters on the features overview page.

  • Also, the table is moved to the separate webstatus-overview-table component.
  • Also, this shows how to use the phosphor icons.

image

jcscottiii
jcscottiii approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@jcscottiii jcscottiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You will need to run make lint-fix to fix the issues.

@dlaliberte
Copy link
Collaborator Author

LGTM. You will need to run make lint-fix to fix the issues.

Thanks. I wonder if we can make this more of an automatic thing.

@dlaliberte dlaliberte merged commit ac918fc into main Feb 12, 2024
3 checks passed
@dlaliberte dlaliberte deleted the dlaliberte-features-02-09 branch February 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrobbins jrobbins jrobbins approved these changes

@jcscottiii jcscottiii jcscottiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlaliberte @jrobbins @jcscottiii