Add a generic entity client for datastore #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaliberte
reviewed
Feb 14, 2024
Previously this client was made specifically for WebFeatures. By moving to generics, we can easily expand support for future entity types. In order to support the generic client, two new interfaces are introduced: - Filterable - Mergeable Filterable allows us to pass custom filters that apply to that entity type Mergeable allows us to define logic for that entity type to describe how to handle merges during updates Also add some tests for this new entity client This is part of splitting up #10 Change-Id: I40ff90582cbb73c11897777e1e72a995669dc12f
jcscottiii
force-pushed
the
jcscottiii/entity-client
branch
from
0cf06e4
to
0de8696
Compare
dlaliberte
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the datastore client was made specifically for WebFeatures.
By moving to generics, we can easily expand support for future entity types (which is already used in #10).
In order to support the generic client, two new interfaces are introduced:
Filterable allows us to pass custom filters that apply to that entity type
Mergeable allows us to define logic for that entity type to describe how to handle merges during updates
Also add some tests for this new entity client
This is part of splitting up #10