structure event summary for type-safety and extensibility #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt1
branch
from
ae36f69 to
5f201e1
Compare
jcscottiii
force-pushed
the
jcscottiii/producer-wiring-pt9
branch
from
86f01d3 to
6250caa
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt1
branch
from
5f201e1 to
0662a36
Compare
jcscottiii
force-pushed
the
jcscottiii/producer-wiring-pt9
branch
from
6250caa to
e6ad352
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt1
branch
from
0662a36 to
afacfa9
Compare
jcscottiii
force-pushed
the
jcscottiii/producer-wiring-pt9
branch
from
e6ad352 to
9b95286
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt1
branch
from
afacfa9 to
0ed7b72
Compare
jrobbins
approved these changes
Dec 30, 2025
jcscottiii
force-pushed
the
jcscottiii/producer-wiring-pt9
branch
from
9b95286 to
9e90d9a
Compare
Overhauls the `EventSummary` structure in `workertypes` to provide strongly-typed, structured data for downstream processing. Key changes: - Introduced generic `Change[T]` type and strongly-typed value structs (`BaselineValue`, `BrowserValue`, `FeatureRef`) to replace raw strings in the summary. Note, there is an existing Change struct that we may want to eventually consolidate with this one. - Added `SummaryHighlightType` and `BrowserName` enums for type safety. - Switched `browser_changes` to a map keyed by `BrowserName`. - Add `MaxHighlights` variable and set it to 10,000 to make the Spanner summary the authoritative "hot" data source (as opposed to the non truncated blob in GCS). Note: We only anticipate 2k-3k features total so this is a very high limit. - Updated `FeatureDiffV1SummaryGenerator` to populate these structured fields.
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt1
branch
from
0ed7b72 to
269ba37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the
EventSummarystructure inworkertypesto provide strongly-typed, structured data for downstream processing.Key changes:
Change[T]type and strongly-typed value structs (BaselineValue,BrowserValue,FeatureRef) to replace raw strings in the summary. Note, there is an existing Change struct that we may want to eventually consolidate with this one.SummaryHighlightTypeandBrowserNameenums for type safety.browser_changesto a map keyed byBrowserName.MaxHighlightsvariable and set it to 10,000 to make the Spanner summary the authoritative "hot" data source (as opposed to the non truncated blob in GCS). Note: We only anticipate 2k-3k features total so this is a very high limit.FeatureDiffV1SummaryGeneratorto populate these structured fields.