feat(api): update subscription triggers and frequencies #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt2
branch
from
b3e90da to
acbcf06
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt3
branch
2 times, most recently
from
f8abdff to
7fcefcd
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt2
branch
from
acbcf06 to
ba99cca
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt3
branch
from
7fcefcd to
c800508
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt2
branch
from
ba99cca to
de06790
Compare
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt3
branch
from
c800508 to
4a35852
Compare
jrobbins
approved these changes
Jan 3, 2026
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt2
branch
from
de06790 to
264e821
Compare
Updates the OpenAPI definition, internal storage types, and worker tests to
align with the V1 notification capabilities, specifically removing `DAILY`
frequency (as it's not in scope for user selection yet) and standardizing
on `IMMEDIATE`, `WEEKLY`, and `MONTHLY`.
Changes:
- **API**:
- Removed `DAILY` frequency.
- Added `IMMEDIATE`, `WEEKLY`, and `MONTHLY` frequencies.
- Renamed and expanded subscription triggers (e.g. `feature_baseline_to_widely`).
- **Storage**:
- Updated `SavedSearchSubscription` struct to use typed `SubscriptionTrigger`
and `JobFrequency` enums.
- Updated Spanner adapters to convert between backend and storage types.
- **Workers**:
- Updated `EventProducer` logic to map `IMMEDIATE` jobs correctly.
- Updated `Dispatcher` tests to use `IMMEDIATE` frequency instead of `DAILY`.
- **Backend**:
- Updated validation logic and tests to match the new enums.
jcscottiii
force-pushed
the
jcscottiii/push-delivery-worker-pt3
branch
from
4a35852 to
f303c60
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: This is to align with the triggers and frequencies in the mocks.
Updates the OpenAPI definition, internal storage types, and worker tests to align with the V1 notification capabilities, specifically removing
DAILYfrequency (as it's not in scope for user selection yet) and standardizing onIMMEDIATE,WEEKLY, andMONTHLY.Changes:
DAILYfrequency.IMMEDIATE,WEEKLY, andMONTHLYfrequencies.feature_baseline_to_widely).SavedSearchSubscriptionstruct to use typedSubscriptionTriggerandJobFrequencyenums.EventProducerlogic to mapIMMEDIATEjobs correctly.Dispatchertests to useIMMEDIATEfrequency instead ofDAILY.