feat(spanner): implement channel state and delivery attempt logging #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
approved these changes
Jan 6, 2026
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt1
branch
from
d4f7e59 to
64c24fa
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt2
branch
from
404e2d0 to
4cf4293
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt1
branch
from
64c24fa to
91cbac5
Compare
Implements the data layer for tracking notification channel health and logging
delivery attempts, which is critical for the Email Worker's reliability logic.
Changes:
- **State Management**: Added `RecordNotificationChannelSuccess` and
`RecordNotificationChannelFailure` methods.
- `Success`: Resets failure count and logs a success attempt.
- `Failure`: Increments failure count (if permanent), checks disable threshold
(5 failures), and logs a failure attempt. Supports transient errors (no
penalty).
- **Transactions**: State updates and attempt logging are performed atomically
within a single read-write transaction.
Other changes: Added some more tests for the list functionality.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt2
branch
from
4cf4293 to
73fcc01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the data layer for tracking notification channel health and logging delivery attempts, which is critical for the Email Worker's reliability logic.
Changes:
RecordNotificationChannelSuccessandRecordNotificationChannelFailuremethods.Success: Resets failure count and logs a success attempt.Failure: Increments failure count (if permanent), checks disable threshold (5 failures), and logs a failure attempt. Supports transient errors (no penalty).Other changes: Added some more tests for the list functionality.