refactor(featurelistdiff): Differentiate between removed and deleted features #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt5
branch
from
cef0d8d to
cd1eb5b
Compare
jrobbins
approved these changes
Jan 14, 2026
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt4
branch
from
d1662da to
3f34413
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt5
branch
from
cd1eb5b to
fb75ef4
Compare
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt4
branch
from
3f34413 to
f13a762
Compare
…features Introduces a clear distinction between features that are truly deleted from the database versus those that are simply no longer present in a given search result (which could be due to a move, split, or rename). Previously, the reconciler would mark a feature as "Removed" and set its reason to "Deleted" if it no longer existed. This approach was ambiguous because the feature remained in the `Removed` list, which is primarily intended for features that might have been moved or split. This change introduces a new `Deleted` slice to the `FeatureDiff` struct. The reconciler logic is updated to check for a feature's existence when it's reported as removed. If it returns an `ErrEntityDoesNotExist`, the feature is moved from the `Removed` list to the new `Deleted` list. This ensures the `Removed` list now accurately contains only features that need to be further analyzed for potential moves or splits, making the diffing process more robust and the resulting data structure clearer.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt5
branch
from
fb75ef4 to
f392e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a clear distinction between features that are truly deleted from the database versus those that are simply no longer present in a given search result (which could be due to a move, split, or rename).
Previously, the reconciler would mark a feature as "Removed" and set its reason to "Deleted" if it no longer existed. This approach was ambiguous because the feature remained in the
Removedlist, which is primarily intended for features that might have been moved or split.This change introduces a new
Deletedslice to theFeatureDiffstruct. The reconciler logic is updated to check for a feature's existence when it's reported as removed. If it returns anErrEntityDoesNotExist, the feature is moved from theRemovedlist to the newDeletedlist.This ensures the
Removedlist now accurately contains only features that need to be further analyzed for potential moves or splits, making the diffing process more robust and the resulting data structure clearer.