Skip to content

Conversation

@tunetheweb
Copy link
Member

Based on these links:

HTML

CSS

@tunetheweb
Copy link
Member Author

Any ideas why the build is failing? Do I need permissions on this repo?

@jrobbins
Copy link
Collaborator

jrobbins commented Jan 8, 2026

Any ideas why the build is failing? Do I need permissions on this repo?

My trivial PR is also having errors. I'm not seeing the cause yet, but I'll try to look into it today.

@jcscottiii
Copy link
Collaborator

The go linter we use released an update

The devcontainer config does not pin the version for the linter, only the go version:

"ghcr.io/devcontainers/features/go:1": {
"version": "1.25.4"
},

Docs about the options

As a result, when the CI ran, it would install the latest version which

Typically, we have been okay with the latest setting. But this is one time it bit us 😢

I will put a fix up shortly to pin to the previous version. Then when I update the go version in the future, I will also bump the linter to the latest version and fix those errors.

@tunetheweb
Copy link
Member Author

I will put a fix up shortly to pin to the previous version. Then when I update the go version in the future, I will also bump the linter to the latest version and fix those errors.

Thanks @jcscottiii . I added the same fix as #2172 to this PR so we could get CI to run, but let's merge your PR first for git history and then this one.

@atopal
Copy link
Collaborator

atopal commented Jan 12, 2026

Thank you Berry Barry! Looks great to me!

@tunetheweb
Copy link
Member Author

"Berry"? I know that's how the American's pronounce it but definitely not how it's spelt! :-)

@jcscottiii jcscottiii added this pull request to the merge queue Jan 12, 2026
Merged via the queue into GoogleChrome:main with commit a447cdd Jan 12, 2026
4 checks passed
@jstenback jstenback mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants