Skip to content

Commit

Permalink
Use android-browser-helper-2.5.0 (#801)
Browse files Browse the repository at this point in the history
  • Loading branch information
andreban authored Jun 13, 2023
1 parent d2a4bd9 commit d05b445
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/lib/features/FeatureManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import {Log, ConsoleLog} from '../Log';
import {ArCoreFeature} from './ArCoreFeature';

const ANDROID_BROWSER_HELPER_VERSIONS = {
stable: 'com.google.androidbrowserhelper:androidbrowserhelper:2.4.0',
alpha: 'com.google.androidbrowserhelper:androidbrowserhelper:2.4.0',
stable: 'com.google.androidbrowserhelper:androidbrowserhelper:2.5.0',
alpha: 'com.google.androidbrowserhelper:androidbrowserhelper:2.5.0',
};

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/spec/lib/features/FeatureManagerSpec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('FeatureManager', () => {
expect(features.applicationClass.onCreate).toEqual([]);
expect(features.applicationClass.variables).toEqual([]);
expect(features.buildGradle.dependencies).toContain(
'com.google.androidbrowserhelper:androidbrowserhelper:2.4.0');
'com.google.androidbrowserhelper:androidbrowserhelper:2.5.0');
expect(features.buildGradle.repositories).toEqual(emptySet);
expect(features.launcherActivity.imports).toEqual(emptySet);
expect(features.launcherActivity.launchUrl).toEqual([]);
Expand All @@ -90,7 +90,7 @@ describe('FeatureManager', () => {
} as TwaManifest;
const features = new FeatureManager(manifest);
expect(features.buildGradle.dependencies).toContain(
'com.google.androidbrowserhelper:androidbrowserhelper:2.4.0');
'com.google.androidbrowserhelper:androidbrowserhelper:2.5.0');
});

it('Adds INTERNET permission when WebView fallback is enabled', () => {
Expand Down

0 comments on commit d05b445

Please sign in to comment.