Add comment to dynamic cache to explain custom code over cache.addAll()

GoogleChromeLabs · Jun 3, 2016 · 03f3a51 · 03f3a51
1 parent 49c8194
commit 03f3a51
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "css-triggers",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "private": true,
   "engines": {
     "node": ">=0.10.0"

diff --git a/src/scripts/sw.js b/src/scripts/sw.js
@@ -51,6 +51,9 @@ function cacheStaticFiles() {
 function cacheDynamicFiles() {
   return caches.open(DYNAMIC_CACHE)
       .then(function(cache) {
+        // We are not using cache.addAll() here because that would stop all
+        // caching on a non 2xx status code. 404.html will be delivered with a
+        // 404 status code, and we want to cache it anyways.
         return DYNAMIC_FILES.map(url => {
           return fetch(url)
               .then(