-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Committer for exactly once sink (#157)
Invoked BQ storage flush API for commit operation
- Loading branch information
1 parent
6aceee8
commit 0f79fba
Showing
6 changed files
with
214 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
...y/src/test/java/com/google/cloud/flink/bigquery/sink/committer/BigQueryCommitterTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| * Copyright 2024 The Apache Software Foundation. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.flink.bigquery.sink.committer; | ||
|
|
||
| import org.apache.flink.api.connector.sink2.Committer.CommitRequest; | ||
|
|
||
| import com.google.api.core.ApiFuture; | ||
| import com.google.cloud.bigquery.storage.v1.FlushRowsResponse; | ||
| import com.google.cloud.flink.bigquery.fakes.StorageClientFaker; | ||
| import com.google.cloud.flink.bigquery.sink.exceptions.BigQueryConnectorException; | ||
| import org.junit.Test; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Collections; | ||
|
|
||
| /** Tests for {@link BigQueryCommitter}. */ | ||
| public class BigQueryCommitterTest { | ||
|
|
||
| @Test | ||
| public void testCommit_withEmptyCommitRequest() throws IOException { | ||
| BigQueryCommitter committer = createCommitter(null); | ||
| // BQ write client used in this test throws a RuntimeException if flushRows is invoked with | ||
| // flushRowsResponse set as null. Since flush should not be called, this commit should not | ||
| // throw any exception. | ||
| committer.commit(Collections.EMPTY_LIST); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCommit() throws IOException { | ||
| BigQueryCommitter committer = | ||
| createCommitter(FlushRowsResponse.newBuilder().setOffset(10L).build()); | ||
| committer.commit( | ||
| Collections.singletonList( | ||
| new TestCommitRequest(new BigQueryCommittable(1L, "foo", 10L)))); | ||
| } | ||
|
|
||
| @Test(expected = BigQueryConnectorException.class) | ||
| public void testCommit_withOffsetMismatch() throws IOException { | ||
| BigQueryCommitter committer = | ||
| createCommitter(FlushRowsResponse.newBuilder().setOffset(5L).build()); | ||
| committer.commit( | ||
| Collections.singletonList( | ||
| new TestCommitRequest(new BigQueryCommittable(1L, "foo", 10L)))); | ||
| } | ||
|
|
||
| @Test(expected = BigQueryConnectorException.class) | ||
| public void testCommit_withFlushRowsApiFailure() throws IOException { | ||
| // BQ write client used in this test throws a RuntimeException if flushRows is invoked with | ||
| // flushRowsResponse set as null. The committer should wrap client errors in a | ||
| // BigQueryConnectorException. | ||
| BigQueryCommitter committer = createCommitter(null); | ||
| committer.commit( | ||
| Collections.singletonList( | ||
| new TestCommitRequest(new BigQueryCommittable(1L, "foo", 10L)))); | ||
| } | ||
|
|
||
| private BigQueryCommitter createCommitter(FlushRowsResponse flushRowsResponse) | ||
| throws IOException { | ||
| return new BigQueryCommitter( | ||
| StorageClientFaker.createConnectOptionsForWrite( | ||
| new ApiFuture[] {null}, null, flushRowsResponse, null)); | ||
| } | ||
|
|
||
| static class TestCommitRequest implements CommitRequest<BigQueryCommittable> { | ||
|
|
||
| private final BigQueryCommittable committable; | ||
|
|
||
| TestCommitRequest(BigQueryCommittable committable) { | ||
| this.committable = committable; | ||
| } | ||
|
|
||
| @Override | ||
| public BigQueryCommittable getCommittable() { | ||
| return committable; | ||
| } | ||
|
|
||
| @Override | ||
| public int getNumberOfRetries() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public void signalFailedWithKnownReason(Throwable t) { | ||
| // Do nothing. | ||
| } | ||
|
|
||
| @Override | ||
| public void signalFailedWithUnknownReason(Throwable t) { | ||
| // Do nothing. | ||
| } | ||
|
|
||
| @Override | ||
| public void retryLater() { | ||
| // Do nothing. | ||
| } | ||
|
|
||
| @Override | ||
| public void updateAndRetryLater(BigQueryCommittable committable) { | ||
| // Do nothing. | ||
| } | ||
|
|
||
| @Override | ||
| public void signalAlreadyCommitted() { | ||
| // Do nothing. | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters