Add tests for AvroToRowDataConvertors (#189)

Add tests since the coverage is low. /gcbrun
GoogleCloudDataproc · Dec 31, 2024 · 6938190 · 6938190
1 parent 4228405
commit 6938190
Show file tree

Hide file tree

Showing 2 changed files with 431 additions and 1 deletion.
diff --git a/...a/com/google/cloud/flink/bigquery/source/reader/deserializer/AvroToRowDataConverters.java b/...a/com/google/cloud/flink/bigquery/source/reader/deserializer/AvroToRowDataConverters.java
@@ -363,7 +363,12 @@ private static int convertToDate(Object object) {
             return (int) ((LocalDate) object).toEpochDay();
         } else if (object instanceof org.joda.time.LocalDate) {
             final org.joda.time.LocalDate value = (org.joda.time.LocalDate) object;
-            return (int) value.toDate().getTime();
+            // 86400000 - number of milliseconds in a day
+            long millisSinceEpoch = value.toDateTimeAtStartOfDay().getMillis();
+            int daysSinceEpoch = (int) (millisSinceEpoch / 86400000);
+            //            return millisSinceEpoch > 0 ? daysSinceEpoch + 1 : daysSinceEpoch;
+            return daysSinceEpoch;
+
         } else {
             String invalidFormatError =
                     getErrorMessage(