Included an unshaded guava specifically for BigQuery usage. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the guava versions used by Flink and BigQuery can be incompatible with each other. The final uber jar of a consumer should include both versions so that Flink and BigQuery connectors can function correctly with their own guava dependency. Without this, Maven will resolve to a single version of guava randomly picked from some transitive dependency and may result in runtime exceptions of a Flink job.
nika-qubit
changed the title
|
/gcbrun |
jayehwhyehentee
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the guava versions used by Flink and BigQuery can be incompatible with each other. The final uber jar of a consumer should include both shaded versions so that Flink and BigQuery connectors can function correctly with their own guava dependency. Without this, Maven will resolve to a single version of guava randomly picked from some transitive dependency and may result in runtime exceptions of a Flink job.
Minor: expanded tabs to whitespaces for the touched poms.
Before the change, guava is a transitive dep (introduced by BigQuery storage) of this project (common jar):
After the change, guava is a direct dep (introduced by the common jar of this project):
The build process (top-right), new jar structure (bot-left) and the old jar structure (bot-right):
You can see that the only addition is the guava jar, which looks like this:
