Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot metrics #182

Merged
merged 24 commits into from
Dec 10, 2024
Merged

Fix snapshot metrics #182

merged 24 commits into from
Dec 10, 2024

Conversation

prashastia
Copy link
Collaborator

Shift since snapshot metrics to snapshotState() rather than first write to prevent leaking the metric values to scope of the next checkpoint.

/gcbrun

@prashastia
Populate User Agent Header and Trace ID to track Read and Write API u…
300194b 
…sage.
@prashastia
Populate User Agent Header and Trace ID to track Read and Write API u…
c11c8ee 
…sage.
@prashastia
Populate User Agent Header and Trace ID to track Read and Write API u…
4e75e1e 
…sage.
@prashastia
Remove the commented out .setTraceId() for
f30c973
@prashastia
Remove User Agent Header from the transport channel.
8549563
@prashastia
throw BigQueryConnector Exception in case of schema mismatch.
7f08506
@prashastia
throw BigQueryConnector Exception in case of schema mismatch.
e4c3f49
@prashastia
Fix No edge case time type.
72d0db2
@prashastia
Merge remote-tracking branch 'dataproc/main' into improve-debuggability
a652677
@prashastia
Remove log messages.
df4741f
@prashastia
Fix day, month and year partition reads along with tests.
64c38c8
@prashastia
Merge remote-tracking branch 'dataproc/main' into troubleshooting-guide
cefd02f
@prashastia
Add TROUBLESHOOT.md
80e8470
@prashastia
Merge remote-tracking branch 'dataproc/main' into troubleshooting-guide
99903c6
@prashastia
Address review changes for code.
e7fd9ea
@prashastia
Address review changes for code.
5fddee2
@prashastia
Merge remote-tracking branch 'dataproc/main' into troubleshooting-guide
39c2ea0
@prashastia
Address review changes for code.
250240c
@prashastia
Remove extra space.
2d179c4
@prashastia
Address Review Comments - elaborate BigQueryConnector Exception.
6acf4d1
@prashastia
Reset Since Checkpoint variables in SnapshotState rather than first w…
5aa3b10 
…rite.
jayehwhyehentee
jayehwhyehentee requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@jayehwhyehentee jayehwhyehentee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the tests, instead of checking if "since checkpoint" counts are zero after "snapshotState", move those checks to a point before "snapshotState" where they have meaningful values.

Presently, with a trivial zero check, tests for those metrics are useless.

@prashastia prashastia self-assigned this Dec 8, 2024
@prashastia prashastia merged commit 5d8b34a into GoogleCloudDataproc:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayehwhyehentee jayehwhyehentee jayehwhyehentee approved these changes

Assignees

@prashastia prashastia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashastia @jayehwhyehentee