Modify GCS Bucket Name for Nightly Build Jar #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before merging:
_GCS_JAR_LOCATION
togs://flink-bq-connector-nightly-job/flink-bq-connector-app-jars
Details:
Currently, the jar is copied to a common named GCS bucket and is then used by Dataproc Clusters to execute the job.
When multiple cloudbuild runs are running simultaneously, this can create a problem as we might loose control over the jar version being tested.
To prevent this, The Jar Name should be modified with a timestamp of execution (like all other aspects in the test). This jar name should then be saved to a file in the VM and used by all the steps(Tests) in the Run.
So now instead of
gs://.../BigQueryIntegrationTest.jar
The jar would be something like -gs://.../[TIMESTAMP]/BigQueryIntegrationTest.jar
gs://.../[TIMESTAMP]/BigQueryIntegrationTest.jar
_GCS_JAR_LOCATION_FILE
_GCS_JAR_LOCATION
variable with_GCS_JAR_LOCATION_FILE
in every step of yaml and read the value ofGCS_JAR_LOCATION
from this file (in therun_test()
function)/gcbrun