Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme, examples and IT tests for table creation. #197

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jayehwhyehentee
Copy link
Collaborator

@jayehwhyehentee jayehwhyehentee commented Jan 13, 2025

Also, deprecate unbounded source.

To clarify, tests have been removed to reduce redundancy, not to hide flaky/failing scenarios.

/gcbrun

Comment on lines -65 to -68
* The sequence of operations in bounded and hybrid pipelines are: <i>source > flatMap > keyBy
* > sum > print</i>. Hybrid pipeline also includes a window operation. <br>
* The sequence of operations in the unbounded pipeline is: <i>source > keyBy > map > sink</i>
* <br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of maintaining the documentation since this is the example file, could we add what the modified pipelines do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need this much detail in the javadoc. Users will need to see the code anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I will remove this pipeline's operation flow part from Table API example file as well

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to remove the flatmap?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It assumes the presence of three columns: "name", "number", "ts". This seems like friction for the users. Our examples should primarily highlight how to use the connector. We can assume that they are already familiar with Flink.

@jayehwhyehentee jayehwhyehentee merged commit c3b5a14 into GoogleCloudDataproc:main Jan 14, 2025
4 checks passed
@jayehwhyehentee jayehwhyehentee deleted the docs_it branch January 14, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants