Use Open Clover for code coverage analysis #48
Conversation
…ed table is expired and no longer accessible.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...igquery/src/main/java/com/google/cloud/flink/bigquery/source/config/BigQueryReadOptions.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/flink/bigquery/source/split/BigQuerySourceSplitAssigner.java
Outdated
Show resolved
Hide resolved
...-bigquery-examples/src/main/java/org/apache/flink/examples/gcp/bigquery/BigQueryExample.java
Outdated
Show resolved
Hide resolved
...bigquery/src/main/java/com/google/cloud/flink/bigquery/common/config/CredentialsOptions.java
Outdated
Show resolved
Hide resolved
...uery/src/main/java/com/google/cloud/flink/bigquery/common/config/BigQueryConnectOptions.java
Outdated
Show resolved
Hide resolved
|
|
||
| private static Credentials createCredentialsFromFile(String file) { | ||
| try { | ||
| return GoogleCredentials.fromStream(new FileInputStream(file)); |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/io/FileInputStream.(Ljava/lang/String;)V) reads a file whose location might be specified by user input
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| */ | ||
| @AutoValue | ||
| @PublicEvolving | ||
| public abstract class BigQuerySource<OUT> |
There was a problem hiding this comment.
AutoValueCouldNotWrite: Could not write generated class com.google.cloud.flink.bigquery.source.AutoValue_BigQuerySource: javax.annotation.processing.FilerException: Attempt to recreate a file for type com.google.cloud.flink.bigquery.source.AutoValue_BigQuerySource
❗❗ 3 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| flink-connector-bigquery/src/main/java/com/google/cloud/flink/bigquery/common/config/CredentialsOptions.java | 34 |
| flink-connector-bigquery/src/main/java/com/google/cloud/flink/bigquery/source/config/BigQueryReadOptions.java | 41 |
| flink-connector-bigquery/src/main/java/com/google/cloud/flink/bigquery/common/config/BigQueryConnectOptions.java | 34 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
...tor-bigquery/src/main/java/com/google/cloud/flink/bigquery/common/utils/SchemaTransform.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/GoogleCloudDataproc/flink-bigquery-connector/48.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/GoogleCloudDataproc/flink-bigquery-connector/48.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
/gcbrun |
|
/gcbrun |
…ed table is expired and no longer accessible.
…driguezdefino/flink-bigquery-connector into add_example_and_shadedsqljar
jayehwhyehentee
force-pushed
the
use_openclover_coverage
branch
from
e306f49 to
07cfd03
Compare
jayehwhyehentee
force-pushed
the
use_openclover_coverage
branch
from
07cfd03 to
a8499c3
Compare
|
/gcbrun |
|
/gcbrun |
| throws Exception { | ||
|
|
||
| final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); | ||
| env.enableCheckpointing(60000L); |
There was a problem hiding this comment.
Can we get this as an user provided configuration
There was a problem hiding this comment.
Addressed the same concern in previous PR (#47).
|
/gcbrun |
jayehwhyehentee
requested review from
jayehwhyehentee and
jayadeep-jayaraman
|
/gcbrun |
jacoco was interfering with surefire and failsafe making the IT tests fail when instrumenting through Jacoco. Open Clover works just fine and is compatible with codecov.