Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare poms for preview release #64

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Prepare poms for preview release #64

merged 1 commit into from
Dec 14, 2023

Conversation

jayehwhyehentee
Copy link
Collaborator

No description provided.

@jayehwhyehentee
Copy link
Collaborator Author

/gcbrun

@@ -24,7 +24,7 @@ under the License.
<parent>
<groupId>com.google.cloud.flink</groupId>
<artifactId>flink-connector-bigquery-parent</artifactId>
<version>1.1-SNAPSHOT</version>
<version>0.1.0-preview</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. But the way we do it in the spark connector is we use a ${revision} maven variable and pass it during the build (nightly, release, etc.) using -Drevision=x.y.z
For nightlies, we use 0.0.yyyyMMdd

Copy link
Collaborator

@vishalkarve15 vishalkarve15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

@jayehwhyehentee jayehwhyehentee merged commit 9252247 into main Dec 14, 2023
4 checks passed
@jayehwhyehentee jayehwhyehentee deleted the preview_release branch December 14, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants