Skip to content

more pom properties refactoring#3434

Open
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260303_updateCommonsLang3PomProperties
Open

more pom properties refactoring#3434
derrickaw wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
derrickaw:20260303_updateCommonsLang3PomProperties

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Mar 3, 2026

  1. Noticed more duplicate pom properties in build(deps): bump org.apache.commons:commons-lang3 from 3.18.0 to 3.20.0 #3431/changes, so just refactoring a little more.
  2. All these removals are already covered in the root pom file.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request continues the effort to refactor Maven POM properties by eliminating duplicate definitions across multiple modules. The changes aim to improve the consistency and maintainability of the project's build configurations, ensuring that properties are defined in a single, authoritative location.

Highlights

  • POM Property Refactoring: Removed redundant Maven properties from several pom.xml files to streamline configurations and eliminate duplication.
  • Dependency Version Cleanup: Specifically removed java.version, commons-lang3.version, junit.version, exec-maven-plugin.version, and project.build.sourceEncoding properties from various module POMs.
Changelog
  • plaintext-logging/pom.xml
    • Removed the 'java.version' property.
  • plugins/core-plugin/pom.xml
    • Removed the 'commons-lang3.version' property.
  • v2/gcs-to-sourcedb/pom.xml
    • Removed the 'junit.version' property.
  • v2/pubsub-binary-to-bigquery/pom.xml
    • Removed the 'exec-maven-plugin.version' property.
  • v2/pubsub-to-redis/pom.xml
    • Removed the 'project.build.sourceEncoding' property.
Activity
  • No review comments or activity have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added the improvement Making existing code better label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.86%. Comparing base (bea7cea) to head (5d60e1e).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3434       +/-   ##
=============================================
+ Coverage     38.11%   51.86%   +13.75%     
- Complexity      613     5866     +5253     
=============================================
  Files           205     1016      +811     
  Lines         14025    61759    +47734     
  Branches       1426     6804     +5378     
=============================================
+ Hits           5345    32031    +26686     
- Misses         8213    27500    +19287     
- Partials        467     2228     +1761     
Components Coverage Δ
spanner-templates 71.63% <ø> (∅)
spanner-import-export 68.92% <ø> (∅)
spanner-live-forward-migration 80.10% <ø> (∅)
spanner-live-reverse-replication 77.52% <ø> (∅)
spanner-bulk-migration 88.35% <ø> (∅)
gcs-spanner-dv 86.78% <ø> (∅)
see 829 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review March 4, 2026 04:08
@derrickaw derrickaw requested a review from a team as a code owner March 4, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant