Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for asyncpg #199

Merged
merged 2 commits into from
Jan 11, 2024
Merged

feat: add support for asyncpg #199

merged 2 commits into from
Jan 11, 2024

Conversation

enocom
Copy link
Member

@enocom enocom commented Jan 9, 2024 •
edited
Loading

Fixes #57.

@enocom enocom requested review from cthumuluru, nancynh and a team as code owners January 9, 2024 15:58
jackwotherspoon
jackwotherspoon requested changes Jan 9, 2024
View reviewed changes
google/cloud/alloydb/connector/asyncpg.py Outdated Show resolved Hide resolved
google/cloud/alloydb/connector/connector.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@enocom enocom force-pushed the asyncpg-support branch 4 times, most recently from 50b4f07 to f8cba72 Compare January 10, 2024 05:22
jackwotherspoon
jackwotherspoon requested changes Jan 10, 2024
View reviewed changes
README.md Show resolved Hide resolved
google/cloud/alloydb/connector/async_connector.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/system/test_asyncpg_connection.py Outdated Show resolved Hide resolved
@enocom enocom force-pushed the asyncpg-support branch 4 times, most recently from 9ea50c7 to 8c5cd85 Compare January 11, 2024 17:49
@enocom enocom force-pushed the asyncpg-support branch 2 times, most recently from 9c3f265 to 3d9ec33 Compare January 11, 2024 18:01
@enocom
Copy link
Member Author

enocom commented Jan 11, 2024

image

jackwotherspoon
jackwotherspoon approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great add @enocom 🥳

tests/system/test_asyncpg_connection.py Outdated Show resolved Hide resolved
@enocom @jackwotherspoon
Update tests/system/test_asyncpg_connection.py
f5843a7 
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
@enocom enocom merged commit d14617b into main Jan 11, 2024
14 of 15 checks passed
@enocom enocom deleted the asyncpg-support branch January 11, 2024 19:17
@release-please release-please bot mentioned this pull request Jan 11, 2024
Merged
@jackwotherspoon jackwotherspoon mentioned this pull request Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

@cthumuluru cthumuluru Awaiting requested review from cthumuluru

@nancynh nancynh Awaiting requested review from nancynh

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for asyncpg driver
2 participants
@enocom @jackwotherspoon