fixup! fix: silent refresh errors on active connection

src/cloud-sql-instance.ts

@@ -63,7 +63,7 @@ export class CloudSQLInstance {
   private readonly authType: AuthTypes;
   private readonly sqlAdminFetcher: Fetcher;
   private readonly limitRateInterval: number;
-  private stablishedConnection: boolean = false;
+  private establishedConnection: boolean = false;
   // The ongoing refresh promise is referenced by the `next` property
   private next?: Promise<RefreshResult>;
   private scheduledRefreshID?: ReturnType<typeof setTimeout> | null = undefined;
@@ -142,18 +142,24 @@ export class CloudSQLInstance {
         // then we go ahead and update values
         this.updateValues(nextValues);
 
-        this.scheduleRefresh();
+
+        const refreshInterval = getRefreshInterval(
+          /* c8 ignore next */
+          String(this.ephemeralCert?.expirationTime)
+        );
+        this.scheduleRefresh(refreshInterval);
 
         // This is the end of the successful refresh chain, so now
         // we release the reference to the next
         this.next = undefined;
       })
       .catch((err: unknown) => {
         // In case there's already an active connection we won't throw
-        // refresh errors to the final user, scheduling a new refresh instead.
-        if (this.stablishedConnection) {
+        // refresh errors to the final user, scheduling a new 
+        // immediate refresh instead.
+        if (this.establishedConnection) {
           if (currentRefreshId === this.scheduledRefreshID) {
-            this.scheduleRefresh();
+            this.scheduleRefresh(0);
           }
         } else {
           throw err as Error;
@@ -234,13 +240,8 @@ export class CloudSQLInstance {
     this.serverCaCert = serverCaCert;
   }
 
-  private scheduleRefresh(): void {
-    const refreshInterval = getRefreshInterval(
-      /* c8 ignore next */
-      String(this.ephemeralCert?.expirationTime)
-    );
-
-    this.scheduledRefreshID = setTimeout(() => this.refresh(), refreshInterval);
+  private scheduleRefresh(delay: number): void {
+    this.scheduledRefreshID = setTimeout(() => this.refresh(), delay);
   }
 
   cancelRefresh(): void {
@@ -253,7 +254,7 @@ export class CloudSQLInstance {
   // Mark this instance as having an active connection. This is important to
   // ensure any possible errors thrown during a future refresh cycle should
   // not be thrown to the final user.
-  setStablishedConnection(): void {
-    this.stablishedConnection = true;
+  setEstablishedConnection(): void {
+    this.establishedConnection = true;
   }
 }

src/connector.ts

@@ -217,7 +217,7 @@ export class Connector {
             await cloudSqlInstance.forceRefresh();
           });
           tlsSocket.once('secureConnect', async () => {
-            cloudSqlInstance.setStablishedConnection();
+            cloudSqlInstance.setEstablishedConnection();
           });
           return tlsSocket;
         }

test/cloud-sql-instance.ts

@@ -185,7 +185,7 @@ t.test('CloudSQLInstance', async t => {
           };
           // starts out refresh logic
           instance.refresh();
-          instance.setStablishedConnection();
+          instance.setEstablishedConnection();
         }))();
     }
   );
@@ -239,7 +239,7 @@ t.test('CloudSQLInstance', async t => {
           };
           // starts out refresh logic
           instance.refresh();
-          instance.setStablishedConnection();
+          instance.setEstablishedConnection();
         }))();
     }
   );
@@ -470,7 +470,7 @@ t.test('CloudSQLInstance', async t => {
       });
 
       await instance.refresh();
-      instance.setStablishedConnection();
+      instance.setEstablishedConnection();
 
       // starts a new refresh cycle but do not await on it
       instance.refresh();
@@ -550,7 +550,7 @@ t.test('CloudSQLInstance', async t => {
           };
           // starts out refresh logic
           instance.refresh();
-          instance.setStablishedConnection();
+          instance.setEstablishedConnection();
         }))();
     }
   );