chore: add port option to tls server test helper #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
approved these changes
Nov 15, 2023
While updating to the new version of our test framework, the tests would start occasionally fail with an `EADDRINUSE` error from trying to connect to an already in use port. This changeset adds an option to the `setup-tls-server` helper module so that we can use different ports in different files that may be run in parallel.
ruyadorno
force-pushed
the
fix-test-port-conflict
branch
from
5737ef8 to
5113699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating to the new version of our test framework, the tests would start occasionally fail with an
EADDRINUSEerror from trying to connect to an already in use port.This changeset adds an option to the
setup-tls-serverhelper module so that we can use different ports in different files that may be run in parallel.