docs: add knex examples #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
add-examples-knex
branch
3 times, most recently
from
8b662e8 to
caf7a6b
Compare
ruyadorno
force-pushed
the
add-examples-knex
branch
from
caf7a6b to
d9b1d2b
Compare
jackwotherspoon
approved these changes
Nov 24, 2023
edosrecki
reviewed
Nov 24, 2023
| const {Connector} = require('@google-cloud/cloud-sql-connector'); | ||
| const knex = require('knex'); | ||
|
|
||
| async function connect({ instanceConnectionName, user, databaseName }) { |
There was a problem hiding this comment.
In the test you are passing argument db and here it is called databaseName. Also, isn't expected property name in connectionOptions called database?
There was a problem hiding this comment.
good catch! fixing it here: #264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds examples of using the connector with
knexforpg,mysql2, andtediousdrivers.Fixes: #111
Includes the original contribution from @edosrecki: #191