Track restartPolicy in node pod informer. #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kubernetes versions that do not support native sidecar, we put an exit file for the sidecar to read once all the containers in the pod have terminated. This behavior partly depends on the RestartPolicy of the Pod. Tracking of this policy was recently removed in #413. Adding it back to Pod.Spec.RestartPolicy in node server pod informer to fix regression in 1.28.
Tested
Ran non-managed driver on cluster running GKE v1.28.15-gke.1020000 and verified auto-termination testsuite succeeds.
cc. @saikat-royc @halimsam