Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuechr/Add automated go version extraction for e2e tests with fuse #429

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chrisThePattyEater
Copy link

@chrisThePattyEater chrisThePattyEater commented Jan 14, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Adds additional step during test to parse '/gcsfuse/tools/cd_scripts/e2e_test.sh' for the version of go being used by fuse teams integration tests and uses that version to run

This has been causing issues for the team while running fuse teams integrations tests because whenever fuse team updates their version of go and our versions are not in sync, integration tests fail causing us to have to manually upgrade the version in the command that runs those integration test as seen in 11e2f8e. This happens about once a month

Which issue(s) this PR fixes:
Fixes # https://buganizer.corp.google.com/issues/379879910

Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?:
n/a

Copy link

google-cla bot commented Jan 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chrisThePattyEater chrisThePattyEater marked this pull request as draft January 14, 2025 19:26
@chrisThePattyEater chrisThePattyEater marked this pull request as ready for review January 14, 2025 19:27
@hime
Copy link
Collaborator

hime commented Jan 16, 2025

Thanks for the detailed description! Could you attach the steps taken to verify this fix? (e.g. results of running the testsuite locally with this change)

@hime hime self-requested a review January 16, 2025 19:04
@chrisThePattyEater chrisThePattyEater changed the title fuechr/b379879910/Add automated go version extraction for e2e tests with fuse fuechr/Add automated go version extraction for e2e tests with fuse Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants