Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HostNetwork enabled e2e test case #450

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

siyanshen
Copy link
Collaborator

This test case covered the IO functionality of a hostnetwork enabled pod.

This PR needs to be checked in ONLY AFTER the hostnetwork PR is checked in.

command to test HTTP protocol:

make e2e-test E2E_TEST_USE_GKE_MANAGED_DRIVER=false E2E_TEST_BUILD_DRIVER=true E2E_TEST_FOCUS=should.successfully.mount.for.hostnetwork.enabled.pods STAGINGVERSION=v999.999.222 REGISTRY=gcr.io/shensiyan-joonix

command to test GRPC protocol

make e2e-test E2E_TEST_USE_GKE_MANAGED_DRIVER=false E2E_TEST_BUILD_DRIVER=true E2E_TEST_FOCUS=should.successfully.mount.for.hostnetwork.enabled.pods STAGINGVERSION=v999.999.222 REGISTRY=gcr.io/shensiyan-joonix GCSFUSE_CLIENT_PROTOCOL=grpc

@siyanshen siyanshen requested a review from hime January 31, 2025 21:21
@siyanshen siyanshen force-pushed the hnw-e2e branch 2 times, most recently from 6e5f996 to 710f165 Compare February 5, 2025 18:48
@siyanshen siyanshen changed the title Add HostNetwork Enabled test case Add HostNetwork enabled e2e test case Feb 5, 2025
@siyanshen siyanshen requested a review from tyuchn February 5, 2025 23:18
@hime
Copy link
Collaborator

hime commented Feb 5, 2025

lgtm (left nit comment on skipping based on versioning)

one thing to consider though, we have a lot of testsuites, it would be good to run some more variations of some of those tests with hostnetworking enabled if there's a possibility of regression there.

@siyanshen siyanshen force-pushed the hnw-e2e branch 4 times, most recently from 19bc330 to 3043617 Compare February 11, 2025 01:49
@siyanshen siyanshen merged commit 504d220 into GoogleCloudPlatform:main Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants