Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
* Fix some docstrings
  • Loading branch information
gargnitingoogle committed Aug 14, 2024
1 parent f6c47eb commit 07ba59d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
9 changes: 5 additions & 4 deletions perfmetrics/scripts/testing_on_gke/examples/dlio/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

"""This program takes in a json test-config file, finds out valid
"""Generates and deploys helm charts for DLIO workloads.
This program takes in a json test-config file, finds out valid
DLIO workloads from it and generates and deploys a helm chart for
each DLIO workload.
each valid DLIO workload.
"""

import argparse
Expand All @@ -33,8 +34,8 @@ def run_command(command: str):
print(result.stderr)


def createHelmInstallCommands(dlioWorkloads: set):
"""Create helm install commands for the given set of dlioWorkload objects."""
def createHelmInstallCommands(dlioWorkloads: set) -> list:
"""Create helm install commands for the given dlioWorkload objects."""
helm_commands = []
for dlioWorkload in dlioWorkloads:
for batchSize in dlioWorkload.batchSizes:
Expand Down
10 changes: 5 additions & 5 deletions perfmetrics/scripts/testing_on_gke/examples/fio/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

"""This program takes in a json test-config file, finds out valid FIO
"""Generates and deploys helm charts for FIO workloads.
workloads from it and generates and deploys a helm chart for each FIO
workload.
This program takes in a json test-config file, finds out valid FIO workloads in
it and generates and deploys a helm chart for each valid FIO workload.
"""

import argparse
Expand All @@ -33,8 +33,8 @@ def run_command(command: str):
print(result.stderr)


def createHelmInstallCommands(fioWorkloads):
"""Create helm install commands for the given set of fioWorkload objects."""
def createHelmInstallCommands(fioWorkloads: set) -> list:
"""Create helm install commands for the given fioWorkload objects."""
helm_commands = []
for fioWorkload in fioWorkloads:
for readType in fioWorkload.readTypes:
Expand Down

0 comments on commit 07ba59d

Please sign in to comment.