Skip to content

Commit

Permalink
remove duplicate Docker file
Browse files Browse the repository at this point in the history
  • Loading branch information
Tulsishah committed Aug 26, 2024
1 parent 4ce79a7 commit 4a93062
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 83 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ set -e
VM_NAME="pytorch2-dino-7d-a100-gpu-hns-bucket"
ZONE_NAME="us-central1-f"
ARTIFACTS_BUCKET_PATH="gs://gcsfuse-ml-tests-logs/ci_artifacts/pytorch/v2_hns/dino"
TEST_SCRIPT_PATH="github/gcsfuse/perfmetrics/scripts/ml_tests/pytorch/v2_hns/dino/setup_host_and_run_container.sh"
TEST_SCRIPT_PATH="github/gcsfuse/perfmetrics/scripts/ml_tests/pytorch/v2/dino/setup_host_and_run_container.sh"
PYTORCH_VERSION="v2"
BUCKET_TYPE="hns"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ then
echo "Clone the gcsfuse repo on test VM"
sudo gcloud compute ssh $VM_NAME --zone $ZONE_NAME --internal-ip --command "mkdir github; cd github; git clone https://github.com/GoogleCloudPlatform/gcsfuse.git; cd gcsfuse; git checkout master;"
echo "Trigger the build script on test VM"
sudo gcloud compute ssh $VM_NAME --zone $ZONE_NAME --internal-ip --command "bash \$HOME/$TEST_SCRIPT_PATH 1> \$HOME/build.out 2> \$HOME/build.err &"
sudo gcloud compute ssh $VM_NAME --zone $ZONE_NAME --internal-ip --command "bash \$HOME/$TEST_SCRIPT_PATH $BUCKET_TYPE 1> \$HOME/build.out 2> \$HOME/build.err &"
echo "Wait for 15 minutes for test VM to setup for test and to change the status from START to RUNNING."
sleep 900s

Expand Down
5 changes: 3 additions & 2 deletions perfmetrics/scripts/ml_tests/pytorch/run_container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
# limitations under the License.
set -e
# pytorch version (e.g. v1_12, v2)
DIR=$1
PYTORCH_VERSION=$1
BUCKET_TYPE=$2

cd "$HOME/github/gcsfuse"
echo "Building docker image containing all pytorch libraries..."
sudo docker build . -f perfmetrics/scripts/ml_tests/pytorch/${DIR}/dino/Dockerfile --tag pytorch-gcsfuse
sudo docker build . -f perfmetrics/scripts/ml_tests/pytorch/${PYTORCH_VERSION}/dino/Dockerfile --tag pytorch-gcsfuse --build-arg PYTORCH_VERSION="${PYTORCH_VERSION}" --build-arg BUCKET_TYPE="${BUCKET_TYPE}"

mkdir -p container_artifacts

Expand Down
4 changes: 2 additions & 2 deletions perfmetrics/scripts/ml_tests/pytorch/v1_12/dino/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ COPY perfmetrics/scripts/ml_tests/pytorch/run_model.sh ./
RUN mkdir -p "run_artifacts"
RUN mkdir -p "gcsfuse_data"

ENV PYTORCH_VERSION="v1_12"
ENV BUCKET_TYPE="non-hns"
ARG PYTORCH_VERSION
ARG BUCKET_TYPE

ENTRYPOINT ["/bin/bash", "-c", "./run_model.sh ${PYTORCH_VERSION} ${BUCKET_TYPE}"]
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ echo "Setting up the machine with Docker and Nvidia Driver"
DRIVER_VERSION="450.172.01"
source ml_tests/setup_host.sh $DRIVER_VERSION

DIR="v1_12"
source ml_tests/pytorch/run_container.sh $DIR
PYTORCH_VERSION="v1_12"
BUCKET_TYPE=$1
source ml_tests/pytorch/run_container.sh $PYTORCH_VERSION $BUCKET_TYPE
4 changes: 2 additions & 2 deletions perfmetrics/scripts/ml_tests/pytorch/v2/dino/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ COPY perfmetrics/scripts/ml_tests/pytorch/run_model.sh ./
RUN mkdir -p "run_artifacts"
RUN mkdir -p "gcsfuse_data"

ENV PYTORCH_VERSION="v2"
ENV BUCKET_TYPE="non-hns"
ARG PYTORCH_VERSION
ARG BUCKET_TYPE

ENTRYPOINT ["/bin/bash", "-c", "./run_model.sh ${PYTORCH_VERSION} ${BUCKET_TYPE}"]
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,7 @@ echo "Setting up the machine with Docker and Nvidia Driver"
DRIVER_VERSION="520.61.05"
source ml_tests/setup_host.sh $DRIVER_VERSION

DIR="v2"
source ml_tests/pytorch/run_container.sh $DIR

PYTORCH_VERSION="v2"
BUCKET_TYPE=$1
source ml_tests/pytorch/run_container.sh $PYTORCH_VERSION $BUCKET_TYPE
45 changes: 0 additions & 45 deletions perfmetrics/scripts/ml_tests/pytorch/v2_hns/dino/Dockerfile

This file was deleted.

This file was deleted.

0 comments on commit 4a93062

Please sign in to comment.