Skip to content

Commit

Permalink
Comment out flaky test (#2481)
Browse files Browse the repository at this point in the history
* Comment out flaky test
  • Loading branch information
kislaykishore authored Sep 17, 2024
1 parent 8fd7dfe commit 50f87ca
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions internal/gcsx/random_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,8 @@ func (t *RandomReaderTest) Test_ReadAt_SequentialToRandomSubsequentReadOffsetLes
ExpectTrue(reflect.DeepEqual(testContent[start3:end3], buf3))
}

// TODO: re-enable test after fixing b/362686470
/*
func (t *RandomReaderTest) Test_ReadAt_CacheMissDueToInvalidJob() {
t.rr.wrapped.fileCacheHandler = t.cacheHandler
objectSize := t.object.Size
Expand Down Expand Up @@ -937,6 +939,7 @@ func (t *RandomReaderTest) Test_ReadAt_CacheMissDueToInvalidJob() {
ExpectTrue(reflect.DeepEqual(testContent, buf))
ExpectEq(nil, t.rr.wrapped.fileCacheHandle)
}
*/

func (t *RandomReaderTest) Test_ReadAt_CachePopulatedAndThenCacheMissDueToInvalidJob() {
t.rr.wrapped.fileCacheHandler = t.cacheHandler
Expand Down

0 comments on commit 50f87ca

Please sign in to comment.